TheCripZone SMF Themes Site

All Things Public => SMF 2.1 RC4 => Archived 2.1.X Versions => 2.1 RC4 Themes => Topic started by: Skhilled on Sep 09, 21, 08:52:54 AM

Title: Ambassador For RC4 Released!
Post by: Skhilled on Sep 09, 21, 08:52:54 AM
Here it is. Kick the tires and take her for a spin. LOL

EDIT: Sorry, the latest update is 11.8.21 below. Found a few issues...
Title: Re: Ambassador For RC4 Released!
Post by: Oldcrow on Sep 09, 21, 10:48:34 AM
Quote from: Skhilled on Sep 09, 21, 08:52:54 AM
Here it is. Kick the tires and take her for a spin. LOL

Nice job. Very nice looking theme skin.
Have a look: https://seniorforums.net/index.php
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Sep 09, 21, 10:54:15 AM
Thanks, Ron. :)

EDIT: Les and worked hard on it.

Special thanks to Sych0 for his valuable help and insight!  O0
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Sep 09, 21, 01:38:07 PM
I almost forgot...you can see a demo of it in the link below until I upgrade the demo site. LOL

https://docskillz.com/smfrc4/index.php
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Sep 12, 21, 12:45:29 PM
Found a few small issues and fixed them.  :-\ The latest update is in the first post.  :coolsmiley:
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Sep 13, 21, 11:54:22 AM
Sorry! Yet another update!  >:( Found a couple of issues...again.  :laugh:

All should be good now.  8) The first post has been updated...
Title: Re: Ambassador For RC4 Released!
Post by: trams on Sep 14, 21, 07:29:53 AM
Hi Skhilled,
I finally found time to install your theme. It seems to work with no issues.

Thank you very much!
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Sep 14, 21, 09:11:19 AM
Thanks for testing it! :)
Title: Re: Ambassador For RC4 Released!
Post by: trams on Nov 03, 21, 12:46:50 PM
Maybe there is an issue. The login button after users log out stop to work showing a popup with "Error".

Here is the related code in index.template.php of Ambassador theme:

<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li>

It seems that

reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login'])

sometimes doesn't work, as you can see in the network tab of browser dev tools.

Does the same happen to you?
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Nov 04, 21, 08:59:37 AM
I don't remember that happening to me remember before but will test it. Thanks for reporting it.

EDIT: Yes, it is happening to me now but never did before. I'm wondering if it has something to do with browsers being updated or something. I'll look into it and thanks, again. :)
Title: Re: Ambassador For RC4 Released!
Post by: trams on Nov 04, 21, 10:40:39 AM
I say thanks to you for your work ;)
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Nov 07, 21, 08:01:50 PM
So far, I've found this while doing a search for the error:

https://github.com/SimpleMachines/SMF2.1/issues/6587

I'm assuming that a RC3 file may have crept into the files by mistake. Just hold off on using it for now while I try to fix it. I may have to start over just to make sure everything is correct. :(
Title: Re: Ambassador For RC4 Released!
Post by: trams on Nov 08, 21, 09:30:11 AM
In the meanwhile here si my workaround:

<ul class="floatleft welcome">
<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return true;', $scripturl . '?action=signup'), '</li>
</ul>';
Title: Re: Ambassador For RC4 Released!
Post by: Skhilled on Nov 08, 21, 10:22:34 AM
Thanks, that does work! :)

EDIT: I'll go with that for now will I check everything to make sure there are no other arising problems. LOL

Latest update is 11.8.21 and has been updated in the first post.