Recent Topics

Members
Stats
  • Total Posts: 10,759
  • Total Topics: 1,375
  • Online today: 98
  • Online ever: 879
  • (Jan 21, 20, 05:49:15 PM)
Users Online
Users: 0
Guests: 101
Total: 101

Ambassador For RC4 Released!

Started by Skhilled, Sep 09, 21, 08:52:54 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Skhilled

Here it is. Kick the tires and take her for a spin. LOL

EDIT: Sorry, the latest update is 11.8.21 below. Found a few issues...

Oldcrow

Quote from: Skhilled on Sep 09, 21, 08:52:54 AM
Here it is. Kick the tires and take her for a spin. LOL

Nice job. Very nice looking theme skin.
Have a look: https://seniorforums.net/index.php

Skhilled

#2
Thanks, Ron. :)

EDIT: Les and worked hard on it.

Special thanks to Sych0 for his valuable help and insight!  O0

Skhilled

I almost forgot...you can see a demo of it in the link below until I upgrade the demo site. LOL

https://docskillz.com/smfrc4/index.php

Skhilled

Found a few small issues and fixed them.  :-\ The latest update is in the first post.  :coolsmiley:

Skhilled

Sorry! Yet another update!  >:( Found a couple of issues...again.  :laugh:

All should be good now.  8) The first post has been updated...

trams

Hi Skhilled,
I finally found time to install your theme. It seems to work with no issues.

Thank you very much!

Skhilled


trams

Maybe there is an issue. The login button after users log out stop to work showing a popup with "Error".

Here is the related code in index.template.php of Ambassador theme:

<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li>

It seems that

reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login'])

sometimes doesn't work, as you can see in the network tab of browser dev tools.

Does the same happen to you?

Skhilled

#9
I don't remember that happening to me remember before but will test it. Thanks for reporting it.

EDIT: Yes, it is happening to me now but never did before. I'm wondering if it has something to do with browsers being updated or something. I'll look into it and thanks, again. :)

trams

I say thanks to you for your work ;)

Skhilled

So far, I've found this while doing a search for the error:

https://github.com/SimpleMachines/SMF2.1/issues/6587

I'm assuming that a RC3 file may have crept into the files by mistake. Just hold off on using it for now while I try to fix it. I may have to start over just to make sure everything is correct. :(

trams

In the meanwhile here si my workaround:

<ul class="floatleft welcome">
<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return true;', $scripturl . '?action=signup'), '</li>
</ul>';

Skhilled

#13
Thanks, that does work! :)

EDIT: I'll go with that for now will I check everything to make sure there are no other arising problems. LOL

Latest update is 11.8.21 and has been updated in the first post.